ui
ui copied to clipboard
fix: “border-boder” “border-primary” duplicates (e.g. “checkbox”, “radio-group”)
What was the problem
- If you didn't include css variables in your initial setup, we converted them, and the special treatment for “border” resulted in duplicate styling for “border”.
Where's the problem with the file?
- transform-css-vars.ts/applyColorMapping Fn
How I fixed it
- We are deduplicating for “border” behind the scenes, but “border-primary” is not caught by this branch (more on why in the link below), so we added a conditional to convert it to “border-boder” when it is not a “border-primary”.
Related issues
-
#4654
-
https://github.com/shadcn-ui/ui/issues/4654#issuecomment-2323113138
Check for PR
- [x] Passed local tests
- [x] Ensure that nothing other than the modification is affected
Someone is attempting to deploy a commit to the shadcn-pro Team on Vercel.
A member of the Team first needs to authorize it.
If this is incorrect, please close it
This PR has been automatically marked as stale due to one year of inactivity. It will be closed in 7 days unless there’s further input. If you believe this PR is still relevant, please leave a comment or provide updated details. Thank you. (This is an automated message)
This PR has been automatically closed due to one year of inactivity. Thank you for your understanding! (This is an automated message)