ui
ui copied to clipboard
Fixed all issues related Command component
Fix Command Component issues and update documentation
Changes
- Resolve Command Component issues by wrapping
<CommandGroup />inside<CommandList> - Update deprecated docs in
combobox.mdxto reflect latest<Command />component usage
Code Changes
From:
<Command>
...
<CommandGroup>
...
</CommandGroup>
</Command>
To:
<Command>
...
<CommandList>
<CommandGroup>
...
</CommandGroup>
</CommandList>
</Command>
Visual Comparison
Before & After comparison:
https://github.com/shadcn-ui/ui/assets/77154365/156b7180-54e6-45aa-8934-b4fb99e6160e
Summary
By wrapping <CommandGroup /> inside <CommandList>{children}</CommandList>, all issues related to the Command Component have been resolved.
@rudrodip is attempting to deploy a commit to the shadcn-pro Team on Vercel.
A member of the Team first needs to authorize it.
@rudrodip any chance you can run pnpm build:registry and push again? Thank you.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| ui | ❌ Failed (Inspect) | Jul 10, 2024 0:41am |
@rudrodip any chance you can run
pnpm build:registryand push again? Thank you.
i've build:registry but it seems like the issues are fixed on the live website
@rudrodip did you commit the new changes and push?
@rudrodip did you commit the new changes and push?
yes i have pushed