ui icon indicating copy to clipboard operation
ui copied to clipboard

Fixed all issues related Command component

Open rudrodip opened this issue 1 year ago • 1 comments

Fix Command Component issues and update documentation

Changes

  • Resolve Command Component issues by wrapping <CommandGroup /> inside <CommandList>
  • Update deprecated docs in combobox.mdx to reflect latest <Command /> component usage

Code Changes

From:

<Command>
  ...
  <CommandGroup>
    ...
  </CommandGroup>
</Command>

To:

<Command>
  ...
  <CommandList>
    <CommandGroup>
      ...
    </CommandGroup>
  </CommandList>
</Command>

Visual Comparison

Before & After comparison:

https://github.com/shadcn-ui/ui/assets/77154365/156b7180-54e6-45aa-8934-b4fb99e6160e

Summary

By wrapping <CommandGroup /> inside <CommandList>{children}</CommandList>, all issues related to the Command Component have been resolved.

rudrodip avatar Jul 03 '24 14:07 rudrodip

@rudrodip is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jul 03 '24 14:07 vercel[bot]

@rudrodip any chance you can run pnpm build:registry and push again? Thank you.

shadcn avatar Jul 10 '24 12:07 shadcn

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ❌ Failed (Inspect) Jul 10, 2024 0:41am

vercel[bot] avatar Jul 10 '24 12:07 vercel[bot]

@rudrodip any chance you can run pnpm build:registry and push again? Thank you.

i've build:registry but it seems like the issues are fixed on the live website

rudrodip avatar Jul 10 '24 12:07 rudrodip

@rudrodip did you commit the new changes and push?

shadcn avatar Jul 10 '24 12:07 shadcn

@rudrodip did you commit the new changes and push?

yes i have pushed

rudrodip avatar Jul 10 '24 12:07 rudrodip