ui icon indicating copy to clipboard operation
ui copied to clipboard

Cleanup: remove unused imports in examples

Open Hidde-Heijnen opened this issue 2 years ago • 3 comments

Cleanup: Removal of Unused Imports

Summary

This pull request involves cleaning up our code by removing several unused imports across multiple files. The aim is to enhance code readability and maintainability.

Changes

The following unused imports have been removed or edited:

  • react-hook-form.tsx in apps/www/components/examples/switch:

    import Link from "next/link";
    import { Checkbox } from "@/components/ui/checkbox";
    import { RadioGroup, RadioGroupItem } from "@/components/ui/radio-group";
    
  • react-hook-form.tsx in apps/www/components/examples/textarea:

    import Link from "next/link";
    import { Checkbox } from "@/components/ui/checkbox";
    import { RadioGroup, RadioGroupItem } from "@/components/ui/radio-group";
    import { Switch } from "@/components/ui/switch";
    
  • demo.tsx in apps/www/components/examples/data-table:

    import { faker } from "@faker-js/faker";
    
  • demo.tsx in apps/www/components/examples/card:

    import { Separator } from "@/components/ui/separator";
    
  • removed , Waves of demo.tsx in apps/www/components/examples/alert:

    import { Terminal, Waves } from "lucide-react";
    
  • removed , FileWarning, Terminal of destructive.tsx in apps/www/components/examples/alert:

    import { AlertCircle, FileWarning, Terminal } from "lucide-react";
    
  • command-menu.tsx in apps/www/components:

    import { allDocs } from "contentlayer/generated";
    

Impact

Some of these unused imports where in files that were used as examples for people to copy, might be nice to clean that up.

I welcome any feedback and appreciate your consideration of this PR!

Hidde-Heijnen avatar May 20 '23 15:05 Hidde-Heijnen

@Hidde-Heijnen is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 20 '23 15:05 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2023 6:28am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-template ⬜️ Ignored (Inspect) May 21, 2023 6:28am

vercel[bot] avatar May 21 '23 06:05 vercel[bot]

@shadcn Is this already fixed in the latest version? Feels weird having switch, radiogroup and checkbox in the form example of the textarea :)

Hidde-Heijnen avatar May 21 '23 08:05 Hidde-Heijnen

@Hidde-Heijnen I believe this is fixed.

Feels weird having switch, radiogroup and checkbox in the form example of the textarea :)

Can you elaborate?

shadcn avatar Aug 03 '23 18:08 shadcn