ui icon indicating copy to clipboard operation
ui copied to clipboard

fix(mdx): rehype pretty code title not showing in light mode

Open RahimGuerfi opened this issue 1 year ago • 4 comments

This commit addresses visibility issues in light mode where the code block title was blending with the white background due to the "text-white" Tailwind class. To improve readability, I changed the title color to black for light themes and white for dark themes, ensuring better contrast and legibility across different modes.

Before applying the fix: before-fix

After applying the fix: after-fix

RahimGuerfi avatar Apr 17 '24 19:04 RahimGuerfi

@RahimGuerfi is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 17 '24 19:04 vercel[bot]

oh man, just saw this now after creating my PR #3552, but I still think my implementation is cleaner, with just text-foreground

flixlix avatar Apr 20 '24 16:04 flixlix

oh man, just saw this now after creating my PR #3552, but I still think my implementation is cleaner, with just text-foreground

it's okay and yeah your implementation is better

RahimGuerfi avatar Apr 20 '24 16:04 RahimGuerfi

This PR has been automatically marked as stale due to one year of inactivity. It will be closed in 7 days unless there’s further input. If you believe this PR is still relevant, please leave a comment or provide updated details. Thank you.

shadcn avatar Apr 20 '25 23:04 shadcn

This PR has been automatically closed due to one year of inactivity. Thank you for your understanding!

shadcn avatar Apr 27 '25 23:04 shadcn