ui icon indicating copy to clipboard operation
ui copied to clipboard

Published 20 hours ago • verified publisher icon shadcn-ui

feat(components): support indeterminate mode for checkbox

Open devbymak opened this issue 1 year ago • 4 comments

Add indeterminate mode for checkbox and document example

devbymak avatar Mar 30 '24 01:03 devbymak

@makarimi76 is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Mar 30 '24 01:03 vercel[bot]

FWIW this is supported in radix-ui.

the ny version removes w/h classes though? props.checked === "indeterminate" ? <DividerHorizontalIcon /> : <CheckIcon /> no longer has w-4 and h-4

cmawhorter avatar Apr 26 '24 14:04 cmawhorter

@cmawhorter In radix-ui, we only have the indeterminate type for checked props. Although it's mentioned in the documentation how to implement it, it's better to have this capability supported by default in Shadcn.

Thank you for reviewing the PR; having w/h in the component was unnecessary. The new revisions have been pushed.

devbymak avatar Apr 28 '24 18:04 devbymak