ui icon indicating copy to clipboard operation
ui copied to clipboard

fix: update destructive color to improve contrast. fixes #281

Open puneet-sarhali opened this issue 2 years ago • 4 comments

Before:

Screen Shot 2023-05-02 at 10 51 26 PM

After:

Screen Shot 2023-05-02 at 10 50 55 PM

Note: Destructive input is just an example, not in the library yet

Other possible solution:

If muted-destructive color is preferred, then the "Alert Component" can be similar to "Destructive Toast Component" like the screenshot below. Screen Shot 2023-05-03 at 1 24 16 AM

But his wouldn't work for input error messages (if implemented similar to first screenshot) because it doesn't usually have a background color.

Using the first approach is similar to the Vercel design system, which has somewhat inspired this lib's choices.

Also, this is my first ever pull request, so any criticism or feedback would be highly appreciated.

puneet-sarhali avatar May 03 '23 08:05 puneet-sarhali

@puneet-sarhali is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 03 '23 08:05 vercel[bot]

fixes #281

puneet-sarhali avatar May 03 '23 08:05 puneet-sarhali

+1 to this. I like the saturation, maybe you could experiment with some slight saturation variations? Maybe this one is good, but maybe a little darker could fit well.

The current one is definitely a bit too dark and contrast lacking imo

dBianchii avatar May 03 '23 17:05 dBianchii

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2023 7:28am

vercel[bot] avatar May 30 '23 07:05 vercel[bot]

@puneet-sarhali I believe we fixed this one in another PR right? It not, please reopen. Thanks.

shadcn avatar Jan 14 '24 08:01 shadcn