ui icon indicating copy to clipboard operation
ui copied to clipboard

Code quality improvements

Open martinez-hugo opened this issue 1 year ago • 5 comments
trafficstars

I manage to upgrade code quality in confidence of StandardJS and Prettier requirements

So, I fix, in first, these formatting issues :

  • JS-R1004
  • JS-D007
  • JS-0372
  • JS-0271

martinez-hugo avatar Jan 08 '24 14:01 martinez-hugo

@martinez-hugo is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jan 08 '24 14:01 vercel[bot]

Add fix for

  • JS-0295
  • JS-0296
  • JS-0400
  • JS-0331

martinez-hugo avatar Jan 08 '24 14:01 martinez-hugo

@shadcn what do you think about this PR ?

martinez-hugo avatar Jan 08 '24 16:01 martinez-hugo

@martinez-hugo Some of the changes I believe conflicts with the original prettier config? I've also not used deepsource before. What does it do?

shadcn avatar Jan 28 '24 09:01 shadcn

Normally Deepsource allow to integrate with Prettier, there also a Transformer available to be compatible with Prettier.

Deepsource have 4 main functionality :

  • Static Code Analysis -> Analyze every pull-request to find and fix code quality issues before you merge to master. No CI setup required.
  • Static Application Security Testing -> Prevent hundreds of known security vulnerabilities in your code and stay compliant with industry standards.
  • Code Coverage -> Measure code coverage metrics and discover lines with missing tests on every pull request. Works with all CI systems.
  • Infrastructure-as-Code Analysis -> Prevent misconfigurations and security vulnerabilities in your infrastructure configuration before deploying to production

Do you want that I implement Deepsource on repo ?

martinez-hugo avatar Jan 28 '24 22:01 martinez-hugo