ui icon indicating copy to clipboard operation
ui copied to clipboard

fix(accordion): removed flickering when using the component with a keyboard

Open davidnussio opened this issue 2 years ago • 4 comments

When navigating the accordion component with the keyboard, there is a small flickering around the ChevronIcon and outline border. Adding a simple pr-1 improves the component's behavior and makes it look good.

Screenshots/GIFs

Before fix:

https://user-images.githubusercontent.com/324371/233770413-b2054c70-109c-4dfd-8540-58a76b2a549d.mp4

After fix:

https://user-images.githubusercontent.com/324371/233770420-76999078-da0f-4741-a8a4-fa8b1ebd2b70.mp4

davidnussio avatar Apr 22 '23 07:04 davidnussio

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2023 8:18am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-template ⬜️ Ignored (Inspect) Apr 30, 2023 8:18am

vercel[bot] avatar Apr 22 '23 07:04 vercel[bot]

@davidnussio is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 22 '23 07:04 vercel[bot]

I think this might be an issue with missing style for focus-visible. Let me see.

shadcn avatar Apr 30 '23 08:04 shadcn

@davidnussio Here's the fix with focus-visible:

https://user-images.githubusercontent.com/124599/235343146-938ca180-a99b-4325-8402-8ed39e77a0d4.mp4

shadcn avatar Apr 30 '23 08:04 shadcn