ui docs(theme): notate source of light-theme hsl vals

docs(theme): notate source of light-theme hsl vals

Open emrosenf opened this issue 2 years ago • 4 comments

This PR adds comments to globals.css to show the origin of the HSL values.

Suggested by @its-monotype and @shadcn in response to #185.

Apr 18 '23 19:04 emrosenf

@emrosenf is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Apr 18 '23 19:04 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 30, 2023 7:49am

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
next-template	⬜️ Ignored (Inspect)	Visit Preview		Apr 30, 2023 7:49am

Apr 19 '23 15:04 vercel[bot]

@emrosenf Can we add the inline comments to the theming doc as well? https://github.com/shadcn/ui/blob/main/apps/www/content/docs/theming.mdx#default

Apr 20 '23 05:04 shadcn

@emrosenf Can we add the inline comments to the theming doc as well? https://github.com/shadcn/ui/blob/main/apps/www/content/docs/theming.mdx#default

Done. Are we just doing the light theme for now? Some of your dark theme colors are not an exact 1:1 from Tailwind colors.

Apr 20 '23 13:04 emrosenf

This could be revisited with the new registry. In colors.ts, each step is defined. You could utilize that for docs.

Nov 12 '23 22:11 Gravy59