shadcn-ui
Selection/Dropdown inside dialog causes memory leak in firefox
Hi, I've implemented selection inside dialog. after testing in firefox. application stops working and on the console it shows
Uncaught InternalError: too much recursion
From my analysis this is the problem of radix-ui . I've tried many methods to prevent this. Now I've mitigated issue by downgraded version from latest to
"@radix-ui/react-dialog": "1.0.4", "@radix-ui/react-dropdown-menu": "^2.0.5", "@radix-ui/react-select": "^1.2.2",
After that it works fine. if anyone faced the same and any other fixes please let me know.
I got this problem as well and commented in #1647. Whenever I click outside of dropdowns the close event triggers twice and clicking on the select trigger again will cause the recursion error to be thrown. My guess is that z-index caused issues with closing, opening and focusing on dropdowns inside a dialog.
If it would be possible then can you assign me to this issue I want to resolve this
I got this problem as well and commented in #1647. Whenever I click outside of dropdowns the close event triggers twice and clicking on the select trigger again will cause the recursion error to be thrown. My guess is that z-index caused issues with closing, opening and focusing on dropdowns inside a dialog.
I fixed this by adding this to package.json
"resolutions": {
"@radix-ui/react-focus-scope": "1.0.4"
}
This will force every @radix-ui/react-focus-scope dependencies to use the same version
@minhson3012 could you please assign me to this issue it would be my 1st contribution
@minhson3012 could you please assign me to this issue it would be my 1st contribution
sorry you'll have to ask the project maintainers for that
@minhson3012 How can I ask him? I mean, how is it possible to connect with them?
This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.
