ui icon indicating copy to clipboard operation
ui copied to clipboard

feat: add file-input component

Open LucasHang opened this issue 2 years ago • 6 comments

While using the template I ran over the need of a file upload input, so I thought in contribute to the project with it. I'm not sure about the whole process to contribute, could not find any documentation on this, but I managed what I think is the basic based on active pull requests of the project.

Here's how the file input looks like: image image image

It could be improved to receive button variant as prop (although I don't see the need) or maybe improve the way I apply the file: modifier. Anything that is missing or you think could be done better, please, let me know.

LucasHang avatar Apr 10 '23 13:04 LucasHang

@LucasHang is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 10 '23 13:04 vercel[bot]

Been looking into this as well. Let's see the preview.

shadcn avatar Apr 12 '23 09:04 shadcn

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2023 6:04pm
ui ❌ Failed (Inspect) Apr 17, 2023 6:04pm

vercel[bot] avatar Apr 12 '23 09:04 vercel[bot]

Should I do something about the Lint error? I can't see whats wrong and I'm not able to install the project dependencies and test it (it complains about next.js version conflict).

LucasHang avatar Apr 12 '23 11:04 LucasHang

@LucasHang I pushed a file input example with the latest update. What do you think?

https://ui.shadcn.com/docs/components/input#file

shadcn avatar Apr 20 '23 12:04 shadcn

@LucasHang I pushed a file input example with the latest update. What do you think?

https://ui.shadcn.com/docs/components/input#file

@shadcn Thats good, and way simpler. Already using instead of my approach, thanks.

LucasHang avatar Apr 20 '23 13:04 LucasHang