sglang
sglang copied to clipboard
[AMD] Add more tests to AMD CI and add diffusion dependencies
Motivation
Added more tests to AMD CI and diffusion dependencies along with a placeholder for diffusion-related test in AMD CI
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist
- [ ] Format your code according to the Format code with pre-commit.
- [ ] Add unit tests according to the Run and add unit tests.
- [ ] Update documentation according to Write documentations.
- [ ] Provide accuracy and speed benchmark results according to Test the accuracy and Benchmark the speed.
- [ ] Follow the SGLang code style guidance.
- [ ] Work with maintainers to merge your PR. See the PR Merge Process
Summary of Changes
Hello @hubertlu-tw, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the AMD Continuous Integration (CI) environment by integrating necessary dependencies for diffusion models and substantially expanding the test coverage. It introduces a more flexible dependency management system for CI scripts and ensures test compatibility by conditionally skipping Flashinfer-related tests on AMD hardware where it's not supported.
Highlights
- Diffusion Dependencies: Added
diffusionas an optional dependency group inpython/pyproject_other.tomland included it in thepip installcommands within thedocker/rocm.Dockerfilefor AMD builds. - Expanded AMD CI Tests: Significantly increased the number of test cases run in the AMD CI suite by adding numerous new test files across various components like quantization, LoRA, and model layers.
- Dynamic Dependency Installation: Modified the AMD CI dependency installation script to support dynamic inclusion of optional Python extras, making the CI setup more flexible.
- Flashinfer Compatibility: Added skip conditions for Flashinfer-based deterministic tests on HIP (AMD) platforms, acknowledging its current lack of support.
Ignored Files
- Ignored by pattern:
.github/workflows/**(1)- .github/workflows/pr-test-amd.yml
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.
/tag-and-rerun-ci