Allow use of Hamilton-Kerr methods with parents dim > 2

Open timothymillar opened this issue 3 years ago • 2 comments

Fixes #906

Sep 20 '22 09:09 timothymillar

Codecov Report

Merging #907 (00ad3d3) into main (2edf8d0) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #907   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           38        38           
  Lines         3200      3204    +4     
=========================================
+ Hits          3200      3204    +4

Impacted Files	Coverage Δ
sgkit/variables.py	`100.00% <ø> (ø)`
sgkit/stats/pedigree.py	`100.00% <100.00%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sep 20 '22 09:09 codecov-commenter

It's not obvious to me where the specification of what's accepted in terms of the parent array is though

Good point, I've added some more documentation and examples which hopefully convey the details.

Sep 21 '22 03:09 timothymillar

Feel free to merge if this is ready @timothymillar

Sep 28 '22 16:09 tomwhite