sgkit icon indicating copy to clipboard operation
sgkit copied to clipboard

Avoid disabling jit on guvectorised functions

Open timothymillar opened this issue 1 year ago • 1 comments

  • [x] Fixes #1194

Leaving NUMBA_DISABLE_JIT=1 for test_pedigree.py which contains many jitted functions.

timothymillar avatar Feb 23 '24 02:02 timothymillar

Hmm, not sure what to do about coverage here

timothymillar avatar Feb 23 '24 02:02 timothymillar

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (6b10a77) to head (e315f52).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              main     #1199    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           52        52            
  Lines         5204      4353   -851     
==========================================
- Hits          5204      4353   -851     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 13 '24 00:03 codecov-commenter

This still runs tests with the jit disabled for two files:

  • sgkit/tests/test_pedigree.py
  • sgkit/tests/io/vcf/test_vcf_writer_utils.py

Both of these files have lots njit functions without guvectorize. This is a bit fragile so we'll see if it sticks around.

I also looked into using pytest to mark certain tests for running with the jit disabled. This doesn't work because the guvectorize functions are compiled at import time which happens even if the tests are deselected.

timothymillar avatar Mar 13 '24 01:03 timothymillar