Shane F. Carr
Shane F. Carr
The `rust-version` for a particular crate can be accessed with the following command: ```shell cargo metadata --format-version 1 | jq '.resolve.root as $root_id | .packages[] | select(.id == $root_id).rust_version' ```...
Concrete proposal: 1. ICU component and provider crates (those in the `icu_` namespace) continue using `rust-version` from the workspace file. We don't do any special MSRV testing beyond what we...
Our utils don't have too many external non-test dependencies, although they definitely have some. If a lockfile update breaks a utils MSRV test, then it means that dependency can't build...
Also, based on the comments above, I should clarify that my mental model was that the utils MSRVs would be less than or equal to the components MSRV. I don't...
@robertbastian Are you unaligned on the motivation or the solution? The motivation for the proposed policy: 1. Utils crates are designed to be more broadly adopted and therefore more likely...
Hi @jugglinmike -- This particular AO has a lot of corner cases that are difficult to cover fully from higher level assertions. It was very helpful when editorially refactoring this...
A few tips to get started. First, review the tutorial here: https://github.com/unicode-org/icu4x/blob/main/docs/process/writing_a_new_data_struct.md Specifically for the percent formatter: you can create a data struct in `experimental/dimension/src/provider.rs`, something like this: ```rust #[icu_provider::data_struct(PercentEssentialsV1Marker...
I also get errors like > error: package `virtual-fs v0.11.0` cannot be built because it requires rustc 1.70 or newer, while the currently active rustc version is 1.67.1 which I...
Here is the output of depscheck with this PR: ``` Found two versions for `syn` (v1.0.109 & v2.0.48) Found non-allowlisted crate `ambient-authority`, consider adding to `EXTRA_DATAGEN_DEPS` or `EXTRA_ZIP_DEPS` or `EXTRA_RAYON_DEPS`...
On main: ``` INFO [icu_datagen::driver] Generated key segmenter/sentence@1 (3.360s, flushed in 64.444ms) INFO [icu_datagen::driver] Generated key segmenter/word@1 (4.779s, flushed in 62.042ms) INFO [icu_datagen::driver] Generated key segmenter/grapheme@1 (4.805s, flushed in 55.470ms)...