Shane F. Carr

Results 1847 comments of Shane F. Carr

Sounds good. When optimizing, please focus on (1) data size and (2) lookup speed. I don't care too much about building speed since it is done offline.

@pdogr Good data on the large map. How does the performance compare on the small version of the map?

It seems that another way to architect this could be to make this a standalone type that maps from keys to an index, and then keep a proper ZeroMap as...

Docs previews: - [icu](http://icu4x-pr-artifacts.storage.googleapis.com/gha/e510d7773e51d041cd17a0c5b2450e378a7ec0bc/docs/icu/index.html)::[decimal](http://icu4x-pr-artifacts.storage.googleapis.com/gha/e510d7773e51d041cd17a0c5b2450e378a7ec0bc/docs/icu/decimal/index.html)::[FixedDecimalFormatter](http://icu4x-pr-artifacts.storage.googleapis.com/gha/e510d7773e51d041cd17a0c5b2450e378a7ec0bc/docs/icu/decimal/struct.FixedDecimalFormatter.html#) [[ Sample for what formatter docs can look like ]] - [icu_decimal](http://icu4x-pr-artifacts.storage.googleapis.com/gha/e510d7773e51d041cd17a0c5b2450e378a7ec0bc/docs/icu_decimal/index.html)::[FixedDecimalFormatter](http://icu4x-pr-artifacts.storage.googleapis.com/gha/e510d7773e51d041cd17a0c5b2450e378a7ec0bc/docs/icu_decimal/struct.FixedDecimalFormatter.html#) - Observation: the links to `icu_provider::constructors` work from `icu_decimal` but not from `icu::decimal`? -...

Every provider is either an `AnyProvider` or a `BufferProvider`. We can currently freely combine providers given that they are in the same class. However, it would be useful if we...

Data transformers and the CrabBake provider are both `AnyProvider`-compatible. They should use `impl_dyn_provider!` which adds the AnyProvider impl.

https://unicode-org.github.io/icu4x-docs/doc/icu_provider/index.html#types-of-data-providers > All nontrivial data providers can fit into one of two classes. > > Type 1: Those whose data originates as structured Rust objects > Type 2: Those whose...

In Temporal: `.year` returns the arithmetic year; `.eraYear` returns the year within the era. In CLDR: Formatting of the chinese calendar uses the cyclic year field in CLDR patterns. Does...

@qcyblm: Please post a test case with the expected result (a line of code that does not behave as expected, with how you expect it to behave).

Yes, if the issue is only that resolvedOptions doesn't round-trip, then the bug is probably around failing to match alternative year fields in the resolved pattern. There are 5 year...