Shane F. Carr comments

Results 1809 comments of


                                            Shane F. Carr

Diplomat: delete default constructor in C++ for transparent structs

https://stackoverflow.com/questions/1069621/are-members-of-a-c-struct-initialized-to-0-by-default

Diplomat: delete default constructor in C++ for transparent structs

I think what we should do is: 1. In docs, encourage people to use the initializer syntax `ICU4XCollatorOptions options = {};` 2. Delete the default constructor to prevent `ICU4XCollatorOptions options;`...

Diplomat: delete default constructor in C++ for transparent structs

@Manishearth Make sure this issue is tracked correctly.

week_of_month seems to be broken

CC @mildgravitas, can you take a look at this?

DateTimeFormat CombinedPattern

@sffc to review and @gregtatum to run a profile on the before and after.

DateTimeFormat CombinedPattern

A few notes: Although 18,818 to 18,659 seems like a small fraction, the fraction will be quite a bit bigger after #1058 is merged. From Greg's flame graphs, it seems...

Use extend() with iterator as appropriate in normalizer and collator

Does #2531 fix this issue?

Use extend() with iterator as appropriate in normalizer and collator

@hsivonen Can you set an assignee (or "help wanted") and a milestone (or "backlog")?

Transformer code for DisplayNames component

@snktd Please merge in main and resolve the conflicts.

Add icu_preferences util

I have some scattered thoughts. But before I get into detail on those, I want to step back and look at what the resulting DTF constructor looks like. I'd like...