Shane F. Carr

Results 1807 comments of Shane F. Carr

@pdogr I think there's time for ICU4X 1.0 to optimize the storage at least for the ULE form of Option TinyAsciiStr. @robertbastian Could you advise on this?

At least for now, I think the NicheOptionULE should show up in ZeroVec bounds. The blanket impl on Option should stay, at least for now (but we can start migrating...

Types that are their own ULE show up in ZeroVec bounds, like TinyAsciiStr. I think it's not unreasonable for NichedOptionULE to be parameterized on AsULE instead of ULE and then...

Yeah, I think the nicest solution is NichedOption that has a Deref to regular Option.

- @zbraniecki - There's a large number of small types in this module. You should import the module, like `fields`, and then everywhere you use it, you write `fields::Year`, etc....

OK, can we assign it to a milestone then? My suggestions: - If this is something you plan to work on this year or early next year, put it in...

Ideally we should be able to make the default constructor populate the fields with default values. But in the short term it may be advisable to delete the default constructor...

POD types like enums and integers are undefined until you set them in C++.

If we want C++ to initialize the values to zero, that's code we need to write (or which Diplomat needs to generate).