Shane F. Carr

Results 1800 comments of Shane F. Carr

@hsivonen Can you set an assignee (or "help wanted") and a milestone (or "backlog")?

Duplicate of https://github.com/unicode-org/icu4x/issues/2182

I think we had discussed that in the context of #2182 but there was some reason it was hard to do. @Manishearth ?

Action: @Manishearth to open or track a Diplomat issue.

@hsivonen What would be an appropriate milestone for this issue?

> or put each character on its own line. Yeah, this is what we should do. I think maybe it used to be that way, until we auto-formatted it. We...

@younies Please review the feedback from Markus and make a PR to improve the docs.

Yes, `FromStr::from_str` and `str::from_utf8` are counter-examples.

@Manishearth @zbraniecki does Robert's comment above change your opinion on this?