Quotes-Generator icon indicating copy to clipboard operation
Quotes-Generator copied to clipboard

Add Missing Author Names

Open seths10 opened this issue 2 years ago • 10 comments

some of the quotes do not have any author, thus they've been dubbed anonymous. Please add the actual author to the particular author if you know his/her name.

seths10 avatar Oct 24 '23 18:10 seths10

This an open issue or you looking for an assignee? Either way I'd like to work on it, researching the authors seems like a good low-code contribution. Pls assign me if that's how it goes.

MojoBoingo avatar Oct 24 '23 19:10 MojoBoingo

hey i would like to contribute to this issue. please assign me.

ChauhanHarshit avatar Oct 25 '23 05:10 ChauhanHarshit

I have assigned both of you to the task @ChauhanHarshit @MojoBoingo

seths10 avatar Oct 25 '23 08:10 seths10

@seths10 👌

MojoBoingo avatar Oct 25 '23 17:10 MojoBoingo

hey @seths10 I'm finding a lot of duplicate quotes just among the ones with anon authors. They are the only ones I'm looking at for the moment, but it's prevalent enough I doubt it's just these. I'm noting the ones I see for deletion, can include that in the PR or not. For now I'm just leaving a comment next to duplicates in the code.

MojoBoingo avatar Oct 25 '23 18:10 MojoBoingo

you can help fix it

seths10 avatar Oct 25 '23 18:10 seths10

deleting duplicates could be a good issue for someone :)

MojoBoingo avatar Oct 25 '23 18:10 MojoBoingo

removing duplicates is already an issue

seths10 avatar Oct 25 '23 18:10 seths10

yeah I realized that. I haven't begun learning JS proper yet so I'll leave writing a script to someone else who needs another PR in the next 6 days. I'd be mostly doing it manually. I am leaving a comment denoting each duplicate I found though. Working on my branch as we speak, will push p soon.

MojoBoingo avatar Oct 25 '23 20:10 MojoBoingo

@seths10 PR sent, found 12 quotes an author.

MojoBoingo avatar Oct 25 '23 20:10 MojoBoingo