Adam Setch

Results 207 comments of Adam Setch
trafficstars

@afonsojramos @bmulholland - I'm pretty happy with the completeness of this initial uplift to use the GitHub Primer UI Components. I plan to update this issue later with before/after screenshots,...

> A minor nitpick: there's now two different versions of green. The Gitify logo in the tray, when there's notifs, is one -- I think the same as open PR...

During further testing, noticed that when a notification row is animating out (mark as read, etc) a horizontal scroll bar is being shown temporarily. Added as an open task to...

> I think open in background is broken on this branch Just tested and it's working for me...

How has the testing been going @bmulholland ? For me it's been really stable. Once this is merged I plan to (finally) move forward with https://github.com/gitify-app/gitify/issues/985 - I have configured...

@afonsojramos - I know you're a busy man atm, but if you do happen to have time to shake this down would love your feedback, too

Appreciate the kind words @afonsojramos and the feedback on some visual inconsistencies. I'll address them shortly 👨‍💻

> However, I've found a couple of visual issues: Apologies this took a while to get back to. Items 1, 2 and 3 have been addressed I think we're getting...

> @setchy do you want some help in the replacement of the `sx`s? Absolutely! Always welcome a friendly hand. I haven't attempted to remove the style components used with primer...