spin icon indicating copy to clipboard operation
spin copied to clipboard

Support deploying without a Dockerfile

Open nckrtl opened this issue 1 year ago • 1 comments

It would be nice to be able to deploy spin projects that do not contain a Dockerfile. For example I have deployed a spin project with just containing a traefik service, allowing to deploy multiple web projects on a single server that use the same Traefik instance.

The +e/-e is needed to make sure the deploy script doesnt exit when no dockerfile is found. This happens on Mac when ls is not returning any results. There might be a better way around this, I'm open for alternatives.

nckrtl avatar Oct 11 '24 10:10 nckrtl

I like where this is going, but I see some other areas where I can improve. Let me keep this open and I will circle back to it 👍

jaydrogers avatar Oct 11 '24 21:10 jaydrogers

Hey Nick! Hope you're well.

I am nearing of launching Spin v3 and this fix will be included. I ran into an issue trying to get your fix merged with my changes on my branch, so I just created a commit. Unfortunately you won't get the credit for the contribution through GitHub though 😢

I am very grateful for you pointing this out though! The AI Overlords also advised me to take a different approach where it's more POSIX-compliant 🤖🙌

Here's the change: https://github.com/serversideup/spin/commit/4bb5a529cf8571b26dfcdfc212e7e436df92f0bf

Good news is you'll be able to deploy images without requiring Dockerfiles in v3.

Thanks again for your help!

jaydrogers avatar Dec 10 '24 21:12 jaydrogers

No worries man, at least its added properly now :) Thanks for looking into it.

nckrtl avatar Dec 10 '24 22:12 nckrtl