serverless-python-requirements icon indicating copy to clipboard operation
serverless-python-requirements copied to clipboard

Update index.js to fix package individually.

Open slslazy opened this issue 4 years ago • 6 comments

The change allows the use of the package individually true combined with sls deploy function -f func_name.

slslazy avatar Nov 30 '21 00:11 slslazy

Hello, could you explain that solution a little bit? Would you be able to cover it with unit test? I'm not sure why/how that solves the problem and would really appreciate a walkthrough 🙇

pgrzesik avatar Nov 30 '21 15:11 pgrzesik

@pgrzesik looks like it's for this issue #605

rileypriddle avatar Dec 02 '21 09:12 rileypriddle

Thanks a lot for linking that @rileypriddle, it indeed seems like the solution to that issue. It would be good to confirm with test case that it solves the issue and we should be good to go with this one @slslazy 🚀

pgrzesik avatar Dec 02 '21 12:12 pgrzesik

Duplicate of #613

rileypriddle avatar Dec 09 '21 15:12 rileypriddle

Hello @slslazy 👋 Are you interested in getting this PR through the finish line? It would be good to confirm that it works as intended with a test case

pgrzesik avatar Jan 09 '22 15:01 pgrzesik

While you wait for this to merge. sed -i 's/inputOpt\.functionObj/this\.serverless\.service\.functions\[inputOpt\.function\]/' node_modules/serverless-python-requirements/index.js

make this a bash function or set as a postinstall step in package.json to replace broken code with working one

keyto123 avatar Jul 27 '22 15:07 keyto123

Thanks @slslazy 🙇 I will finalize it as a part of: https://github.com/serverless/serverless-python-requirements/pull/725 after stabilizing tests. I will close this PR.

pgrzesik avatar Sep 27 '22 18:09 pgrzesik