serilog-settings-configuration icon indicating copy to clipboard operation
serilog-settings-configuration copied to clipboard

Published 20 hours ago • verified publisher icon serilog

ConfigurationReader.FindConfigurationExtensionMethods relies on one specific implementation of ExtensionAttribute

Open sajagi opened this issue 3 years ago • 1 comments

The method (ConfigurationReader.FindConfigurationExtensionMethods) should not rely on specific ExtensionAttribute type present in System.Runtime.dll, but rather on any type with matching name.

The attribute can be polyfilled in any assembly to enable extension method support.

In one (my) case this attribute is implemented in nunit.engine.core assembly which leads Serilog to not recognize extension methods when running tests using e.g. nunit3-console.

Happy to provide a PR.

sajagi avatar Apr 07 '22 14:04 sajagi

PR would be great, thanks. We should be able to squeeze this into #299.

nblumhardt avatar Apr 07 '22 22:04 nblumhardt