serilog-sinks-elasticsearch icon indicating copy to clipboard operation
serilog-sinks-elasticsearch copied to clipboard

Published 20 hours ago • verified publisher icon serilog-contrib

default typeName is null since _type is removed in ESv7 and unsupported in ESv8+

Open patrikbeno opened this issue 3 years ago • 1 comments
trafficstars

…in ESv8+

What issue does this PR address?

#375

Does this PR introduce a breaking change?

Technically, yes, but since _type is unsupported in ESv8+, then NO. You can't break what is already broken.

Please check if the PR fulfills these requirements

  • [ ] The commit follows our guidelines
  • [ ] Unit Tests for the changes have been added (for bug fixes / features)

Other information:

current default is a blocker when trying to configure ES sink from json/yaml, since typename=null or typename="" is just ignored and default typename="_doc" remains in place

patrikbeno avatar Jun 27 '22 17:06 patrikbeno

I am also having issues with Serilog.Sinks.Elasticsearch to Elasticsearch 8.x. I would just love that, whatever implementation goes forward to fix the issue with 8.x does not break 7.x. We have enough problems using this package already.

nenadvicentic avatar Aug 11 '22 14:08 nenadvicentic