wave icon indicating copy to clipboard operation
wave copied to clipboard

Published 20 hours ago • verified publisher icon seqeralabs

Support adding layers and context to container build

Open munishchouhan opened this issue 2 months ago • 4 comments

This PR will do the following:

  1. Fix posix permission issue in singulairty build when untar layers
  2. Fix posix permission issue when untar context

munishchouhan avatar Sep 04 '25 15:09 munishchouhan

I think this can be simplified without handling in a special case the saving of build context and layers for singularity

https://github.com/seqeralabs/wave/blob/347182472ae26716267d442214b9282301a4a760/src/main/groovy/io/seqera/wave/service/builder/impl/ContainerBuildServiceImpl.groovy#L272-L279

In both cases, Wave should only take case of saving the tar in the build work dir (s3 path). then mounting that path in the content. Finally Dockerfile add it/them to the container using one or more ADD, instead singularity using a %post script to untar and copy in the right directory

pditommaso avatar Sep 08 '25 08:09 pditommaso

Tested singularity in dev: https://wave.dev-seqera.io/view/builds/bd-f3d0dbf41f09b917_1

munishchouhan avatar Sep 09 '25 07:09 munishchouhan

tested docker with context https://wave.dev-seqera.io/view/containers/5f81208b7fae

munishchouhan avatar Sep 09 '25 13:09 munishchouhan

tested singulairty with context https://wave.dev-seqera.io/view/builds/bd-553d7de13471d357_1

munishchouhan avatar Sep 09 '25 14:09 munishchouhan