wave icon indicating copy to clipboard operation
wave copied to clipboard

Enable streaming of build logs

Open munishchouhan opened this issue 1 year ago • 10 comments

This PR will enalbe log streaming to get build log endpoint, while build is in process

munishchouhan avatar Apr 17 '24 16:04 munishchouhan

@pditommaso is this required or should it refresh automatically?

https://github.com/seqeralabs/wave/assets/6575288/8fed1038-a6f7-4ca8-8ad1-ec0bda198900

munishchouhan avatar Apr 18 '24 15:04 munishchouhan

If only build box content is refreshed while the status is PENDING, it would be cool

pditommaso avatar Apr 18 '24 15:04 pditommaso

If only build box content is refreshed while the status is PENDING, it would be cool

I will give it a try

munishchouhan avatar Apr 18 '24 15:04 munishchouhan

@pditommaso build logs with refresh now

https://github.com/seqeralabs/wave/assets/6575288/e800b0a6-7092-4707-8ad2-e134ad4231bf

munishchouhan avatar Apr 18 '24 20:04 munishchouhan

@pditommaso its ready for review

munishchouhan avatar Apr 19 '24 14:04 munishchouhan

I have moved the docs changes to https://github.com/seqeralabs/wave/pull/464 it will easier to apply once the docs repo is in sync with wave

munishchouhan avatar Apr 22 '24 13:04 munishchouhan

Suggestion from @ewels Was thinking about what you were saying about ASCII codes in the logs yesterday . I wonder if we can keep them (maybe via a flag in the API?). I would love to be able to render the colours if possible as it makes the logs much easier to read. The back-end used by Hub is written Python, and my favourite library Rich is able to convert ascii codes to html. So we might be able to do that on the round trip and preserve colour. On the Wave side we just have to not throw them out. What do you think?

munishchouhan avatar May 15 '24 08:05 munishchouhan

Please keep colour outside of this PR. We need fist makes the logs stream to work

pditommaso avatar May 15 '24 09:05 pditommaso

Please keep colour outside of this PR. We need fist makes the logs stream to work

I will create another issue

munishchouhan avatar May 15 '24 09:05 munishchouhan

merged get messed up, moving to draft

munishchouhan avatar Oct 17 '24 03:10 munishchouhan