wave
wave copied to clipboard
Enable streaming of build logs
This PR will enalbe log streaming to get build log endpoint, while build is in process
@pditommaso is this required or should it refresh automatically?
https://github.com/seqeralabs/wave/assets/6575288/8fed1038-a6f7-4ca8-8ad1-ec0bda198900
If only build box content is refreshed while the status is PENDING, it would be cool
If only build box content is refreshed while the status is PENDING, it would be cool
I will give it a try
@pditommaso build logs with refresh now
https://github.com/seqeralabs/wave/assets/6575288/e800b0a6-7092-4707-8ad2-e134ad4231bf
@pditommaso its ready for review
I have moved the docs changes to https://github.com/seqeralabs/wave/pull/464 it will easier to apply once the docs repo is in sync with wave
Suggestion from @ewels Was thinking about what you were saying about ASCII codes in the logs yesterday . I wonder if we can keep them (maybe via a flag in the API?). I would love to be able to render the colours if possible as it makes the logs much easier to read. The back-end used by Hub is written Python, and my favourite library Rich is able to convert ascii codes to html. So we might be able to do that on the round trip and preserve colour. On the Wave side we just have to not throw them out. What do you think?
Please keep colour outside of this PR. We need fist makes the logs stream to work
Please keep colour outside of this PR. We need fist makes the logs stream to work
I will create another issue
merged get messed up, moving to draft