xrpl-rust icon indicating copy to clipboard operation
xrpl-rust copied to clipboard

Revise current models

Open LimpidCrypto opened this issue 2 years ago • 0 comments

There are some improvements need to be done to the current models for transactions and requests:

  • [x] utilize Default, PartialEq, Eq, Clone traits
  • [x] split up Currency into Currency and Amount
    • [x] Currency::Xrp must have fiel name currency
  • [x] add tests for serializing and deserializing models
    • [x] add macro to serialize and deserialize a struct with its tag (e.g. {"StructName": {"foo": 0, "bar": 1}})
  • [x] change impl lifetimes
  • [x] cleanup models/mod.rs (e.g StreamParameter should be in requests/subscribe.rs)
  • [ ] add non-common-fields documentation
  • [x] look over request_fields.rs and move to models/requests
  • [ ] Add signing request methods with feature flag
  • [x] Add ˋnewˋ methods to all models
    • [x] change tests to use new

LimpidCrypto avatar Jan 27 '23 22:01 LimpidCrypto