sendgrid-python icon indicating copy to clipboard operation
sendgrid-python copied to clipboard

feat: add support for python3.12

Open meysam81 opened this issue 1 year ago • 2 comments

Python3.12

fixes #1086

Checklist

  • [x] I acknowledge that all my contributions will be made under the project's license
  • [x] I have made a material change to the repo (functionality, testing, spelling, grammar)
  • [x] I have read the Contribution Guidelines and my PR follows them
  • [x] I have titled the PR appropriately
  • [x] I have updated my branch with the main branch
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] I have added the necessary documentation about the functionality in the appropriate .md file
  • [x] I have added inline documentation to the code I modified

meysam81 avatar Aug 24 '24 03:08 meysam81

@tiwarishubham635 I don't have permission to assign a reviewer to the PR. But here you are. Please review.

meysam81 avatar Aug 24 '24 03:08 meysam81

@tiwarishubham635 any updates on this?

corbinday avatar Sep 27 '24 15:09 corbinday

This looks good to me, just we can skip the Makefile change I feel. Also, can you add support for python 3.13 as well, else I'll have to raise a separate PR.

tiwarishubham635 avatar Apr 11 '25 11:04 tiwarishubham635

@tiwarishubham635

This pull request has been around for a year now.

For additional required changes, maintainers have access to modify the contents of this pull request. :point_down:

gh-pr

Cheers. :clinking_glasses:

meysam81 avatar Apr 12 '25 03:04 meysam81

@tiwarishubham635

This pull request has been around for a year now.

For additional required changes, maintainers have access to modify the contents of this pull request. 👇

gh-pr

Cheers. 🥂

Thanks for this @meysam81! I have made the changes. One last thing before merging this. Is there any specific reason why we are adding setuptools to our requirements.txt?

tiwarishubham635 avatar Apr 12 '25 09:04 tiwarishubham635

Yes, this is the reason 👇

Screenshot 2025-04-12 at 16 27 16

meysam81 avatar Apr 12 '25 09:04 meysam81