sendgrid-python icon indicating copy to clipboard operation
sendgrid-python copied to clipboard

fix: Ignore submodules in test directory

Open davismr opened this issue 2 years ago • 0 comments

so they are not installed under test folder in python site-packages

Also remove the temp*.py exclusion as this does not seem to have any purpose

Fixes

Installing sendgrid will also install test folder, with two sub folders in site-packages. This can create conflicts at worst and creates noise at best. Currently test folder is ignore in find_packages, but tests have been split into sub-modules and the find_packages exclude attribute was not updasted.

To test, install current main branch. Confirm test folder is in site-packages. Uninstall sendgrid, delete test folder in site-packages, delete *.egg-info folder, delete build folder, reinstall. test folder is no longer installed

Checklist

  • [x] I acknowledge that all my contributions will be made under the project's license
  • [x] I have made a material change to the repo (functionality, testing, spelling, grammar)
  • [x] I have read the Contribution Guidelines and my PR follows them
  • [x] I have titled the PR appropriately
  • [x] I have updated my branch with the main branch
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added the necessary documentation about the functionality in the appropriate .md file
  • [ ] I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

davismr avatar Aug 22 '23 23:08 davismr