sendgrid-go icon indicating copy to clipboard operation
sendgrid-go copied to clipboard

Published 20 hours ago • verified publisher icon sendgrid

Go Mail Helper Refactor

Open thinkingserious opened this issue 8 years ago • 9 comments

Issue Summary

An interface to easily interact with the mail/send endpoint of the SendGrid v3 Web API.

The specification for this project is here.

Acceptance Criteria

All of the use cases defined here are implemented and all corresponding tests are passing.

thinkingserious avatar Oct 10 '17 20:10 thinkingserious

I got it

suchitparikh avatar Oct 10 '17 20:10 suchitparikh

@dtjm @extemporalgenome @Dharmik-Patel @deckarep @0sc @berto

If you are tagged on this message, it means we are particularly interested in your feedback :)

If you don't have the time, no worries and my apologies for the disturbance.

If you do have the time, please take a look at the proposed helper upgrade above and let us know what you think. Any and all feedback is greatly appreciated.

Thanks in advance!

thinkingserious avatar Oct 10 '17 20:10 thinkingserious

@thinkingserious which link did you want us to review?

dtjm avatar Nov 28 '17 17:11 dtjm

Hi @dtjm!

The relevant links are in the Issue Summary above.

Specifically, this link is the proposed specification and this link is the discussion around that proposal. And the goal is to implement these use cases.

Thanks!

With Best Regards,

Elmer

thinkingserious avatar Nov 28 '17 21:11 thinkingserious

Hi, I have two suggestions:

  1. we need to define interface and generate mock for user easily to test once they are integrating this package, can reference this issue: https://github.com/sendgrid/sendgrid-go/issues/36

  2. we need a kind of NewBatchEmail function to support send multiple recipients in the same time, more can reference here: https://github.com/sendgrid/sendgrid-go/issues/247

thanks for your reading, I can help contributing if those suggestions are accepted and you need

hothero avatar Jan 05 '18 05:01 hothero

@thinkingserious I found above message is changed to work in progress, where we can follow the related progress and make contribution?

hothero avatar May 07 '18 16:05 hothero

@suchitparikh ^^

thinkingserious avatar May 08 '18 00:05 thinkingserious

Hello here. Is this issue still in progress ?

Having this interface would really be nice. Also, providing a default mock using testify could be a simple way to allow lot of people to use it.

Having to make a wrapper for unit testing is quite annoying 👍 :)

Thanks for your work 👍

titouanfreville avatar Jun 04 '20 20:06 titouanfreville

@titouanfreville Nope, looks like there is no one currently working on this issue.

childish-sambino avatar Jun 16 '20 15:06 childish-sambino