jsduck icon indicating copy to clipboard operation
jsduck copied to clipboard

Published 20 hours ago • verified publisher icon senchalabs

UI Template: Fix input in search and filter

Open olecom opened this issue 10 years ago • 2 comments

olecom avatar Feb 20 '15 02:02 olecom

Hi.

Thanks for the contribution. But could you be so kind and describe briefly the bug that this pull request is supposed to fix.

I could go through the commits and figure it out by myself, but I think it should be your responsibility to convince me about the usefulness of this patch.

nene avatar Feb 23 '15 07:02 nene

Right, sorry.

  1. Filter is noticeably slow (e.g. on laptops in battery saving mode or when OS is overloaded) thus it's a good idea to buffer input a bit and don't do filtering right from the first character btw, Search is deferred by basicSearchDelay

  2. both Filter and Search: input by context menu (mouse right click) when pasting text via mouse + context menu nothing happens (jsDuck in ExtJS 5.1): image

image

non changing behavior patch https://github.com/olecom/jsduck/commit/9eb91e2d0226d5e78e7fa35b3d9962ac21f89efd allows isolated implementation of the fix in https://github.com/olecom/jsduck/commit/1a9be9d4cd4edf51fcb3e7b12a386b6e863acc02

  1. get rid of blind use of optimization killer arguments (can be skipped)

olecom avatar Feb 26 '15 18:02 olecom