semaphore icon indicating copy to clipboard operation
semaphore copied to clipboard
verified publisher icon semaphoreui

Fix base URI not included in generated OpenID Connect URLs (#1524)

Open hmoffatt opened this issue 2 years ago • 9 comments

OpenID Connect login does not work when the base URI includes a path component. This PR fixes this.

hmoffatt avatar Oct 15 '23 23:10 hmoffatt

HI @fiftin it would be great if you can review this, it is a relatively simple change but OIDC + sub-path on the URL does not work without it. Thanks.

hmoffatt avatar Feb 05 '24 08:02 hmoffatt

Since these changes have been approved, could this PR be merged, soon? Currently, using OpenID-Connect with SEMAPHORE_WEB_ROOT is broken.

ChristianCiach avatar Mar 07 '24 12:03 ChristianCiach

Any movement on this PR? I'd like to call out the documentation suggests doing this for those who run reverse proxies.

https://docs.semui.co/administration-guide/configuration#public-url

After two days of OIDC troubleshooting, coming across this was a relief.

stuntguy3000 avatar Mar 22 '24 02:03 stuntguy3000

Huh, is anybody here?

veshus avatar Jul 17 '24 19:07 veshus

I have rebased this against the current develop, @fiftin perhaps you have a chance to have a look? I have my Semaphore hosted at https://domain.com/semaphore and it is working for me with this change.

hmoffatt avatar Jul 18 '24 04:07 hmoffatt