semaphore icon indicating copy to clipboard operation
semaphore copied to clipboard

External signal hashing

Open cedoor opened this issue 3 years ago • 0 comments

Is your feature request related to a problem? Please describe.

Sometimes it is not necessary to hash the signal on-chain. Letting developers choose how to pass the signal would make the protocol even more generic and give more freedom. However, best practice should be to hash the signal with a value that can be used as a reference to get the original value off-chain (e.g. IPFS).

Describe the solution you'd like

The signal hash with keccak256 could be removed from the SemaphoreCore.sol contract.

cedoor avatar Aug 29 '22 08:08 cedoor