self-xdsd
#262 "Tasks" card improvements.
@criske thank you for your Pull Request. I'll assign someone to review it soon.
@amihaiemil please review this Pull Request. Deadline (when it should be merged or closed) is 2021-01-13T15:26:10.383088.
You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.
Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.
@amihaiemil
~~Now that I'm looking at those values, something is wrong there?
In my db, the closed task has a value of 150euro and comission rate of 0.5. It looks like the Task from InvoicedTask ("closed" one) has the commission included in value, but the active tasks don't. Is this the correct behaviour?~~
Nvm: the task value for the closed one is ok, just checked the comission is in euro not in percent and is not added to the value.
@criske it looks nice, but same as the other PR with big table changes, let's postpone the merge a little bit.
@charlesmike deregister
@amihaiemil ok, I've removed this task from scope. I'm not managing it anymore.
@amihaiemil I'll add tests for StatusTasks#active and StatusTasks#closed methods later (these aren't use anywhere at the moment anyway). StatusTasks#all() is tested along with ContractsApi#tasks endpoint and works fine.