self-web icon indicating copy to clipboard operation
self-web copied to clipboard

#258 Improvements for table pagination, search input and filters.

Open criske opened this issue 4 years ago • 8 comments

closes #258

  • moved "Show entries per page" before the pagination

  • tweaks on pagination ux (smaller buttons, icons for next/previous page).

  • project contracts can be searched only by "Contributor" and search input has placeholder now.

  • "options" column in "Contracts" can't be ordered anymore. contracts_table

  • used datatables Search Builder plugin to filter dates (assigned and deadline) in "Tasks" table and created in "Invoices" table. date_filter


since is the last day before this puzzle deadline, left puzzle to fix created date filtering in "Invoices", somehow is not working...

criske avatar Jan 03 '21 09:01 criske

@criske thank you for your Pull Request. I'll assign someone to review it soon.

charlesmike avatar Jan 03 '21 09:01 charlesmike

@amihaiemil please review this Pull Request. Deadline (when it should be merged or closed) is 2021-01-06T11:48:50.146142.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

charlesmike avatar Jan 03 '21 09:01 charlesmike

@criske thanks! However, we will not merge this yet because these are very big changes which I would like to cover in the next QA round after we go to Prod.

Let's leave the PR open, I closed the Issue. I also sent a bonus of 2 more hours since this is clearly more than 1h work :D

amihaiemil avatar Jan 04 '21 17:01 amihaiemil

@amihaiemil thanks! :D, also can I fix here the date filtering in "Invoices" table, now there is more time...?

criske avatar Jan 04 '21 17:01 criske

@criske yes, sure :D

amihaiemil avatar Jan 04 '21 17:01 amihaiemil

@amihaiemil Don't forget to close this ticket before the deadline (2021-01-06T11:48:50). You are past the first half of the allowed period.

charlesmike avatar Jan 04 '21 22:01 charlesmike

@charlesmike deregister

amihaiemil avatar Jan 05 '21 12:01 amihaiemil

@charlesmike deregister

@amihaiemil ok, I've removed this task from scope. I'm not managing it anymore.

charlesmike avatar Jan 05 '21 12:01 charlesmike