PcapPlusPlus icon indicating copy to clipboard operation
PcapPlusPlus copied to clipboard

Replaced IPNetwork's raw pointer usage with smart pointers.

Open Dimi1010 opened this issue 1 year ago • 2 comments

Main points of this PR are the replacement of raw pointers, new and delete calls in IPNetwork with usages of std::unique_ptr<T> and a backported implementation of std::make_unique.

Dimi1010 avatar Apr 26 '24 12:04 Dimi1010

Also, just asking, is it desirable for internal detail namespaces to be documented in the public API documentation?

Dimi1010 avatar Apr 26 '24 12:04 Dimi1010

Also, just asking, is it desirable for internal detail namespaces to be documented in the public API documentation?

yes, we should document everything.

tigercosmos avatar Apr 26 '24 13:04 tigercosmos