analytics.js-integrations icon indicating copy to clipboard operation
analytics.js-integrations copied to clipboard

Published 20 hours ago • verified publisher icon segmentio

[segmentio] Drop the event when message exceeds the maximum size

Open gglavan-ellation opened this issue 4 years ago • 1 comments

Hi 👋 . Is there any reason why the segmentio integration doesn't drop the event when the message exceeds the maximum size as the analytics-ios and analytics-android SDKs do? Looking through the files it seems like this was actually considered a year ago. https://github.com/segmentio/analytics.js-integrations/blob/a33206aac3dccf6b4c5b3166a0ebdb4fd23c5e5d/integrations/segmentio/lib/index.js#L377-L378

I'm willing to open a PR if that is still considered.

gglavan-ellation avatar May 11 '21 11:05 gglavan-ellation

I have opened a PR to change this: https://github.com/segmentio/analytics.js-integrations/pull/599

gglavan-ellation avatar May 11 '21 12:05 gglavan-ellation