analytics.js-integrations icon indicating copy to clipboard operation
analytics.js-integrations copied to clipboard

Add try catch around UET type error. Bump version

Open montnyc opened this issue 5 years ago • 2 comments

Closes https://github.com/segmentio/analytics.js-integrations/issues/342

What does this PR do? Catches a TypeError when initializing the Bing Ads integration on some browsers

Are there breaking changes in this PR? No

Any background context you want to provide? We receive this error hundreds of times, so do others see this issue.

Is there parity with the server-side/android/iOS integration components (if applicable)? N/A

Does this require a new integration setting? If so, please explain how the new setting works No

Links to helpful docs and other external resources

montnyc avatar Jul 06 '20 22:07 montnyc

Screen Shot 2020-07-06 at 6 27 02 PM

Tests run locally. Sorry to ping @CarlosMecha

montnyc avatar Jul 06 '20 22:07 montnyc

Hi @constmontague , I did the same exact thing before you, here https://github.com/segmentio/analytics.js-integrations/pull/490/files 😛 I'm happy that you've opened another PR tho as it increased the chances of this being fixed, but apparently that's not what happened hahah. @gpsamson pretty please? :)

lekterable avatar Aug 03 '20 08:08 lekterable