seekr
seekr copied to clipboard
fix dropdown bug in guide
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
- [ ] Project infrastructure change (like issue templates, etc.)
How Has This Been Tested?
Please check all browsers you have tested on. Please also list any relevant details for your test configuration
- [ ] Chromium Based Browser
- [ ] Mozilla Firefox
Test Configuration:
- [ ] Windows
- [ ] Linux
- [ ] MacOS
- [ ] BSD
Checklist:
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream modules
- [ ] I am a web developer
my sanity is draining
divine interventions are hindering querySelector from working properly
A in dropdown value change listener is still missing but that's not that hard to add
why do you use an innerhtml here @9glenda
why do you use an innerhtml here @9glenda
@Niteletsplay You mean test1? It's the ID/name of the dropdown.
why do you use an innerhtml here @9glenda
@Niteletsplay You mean test1? It's the ID/name of the dropdown.
Cant you just use an attribute like title="test1"?
why do you use an innerhtml here @9glenda
@Niteletsplay You mean test1? It's the ID/name of the dropdown.
Cant you just use an attribute like title="test1"?
I'll change it to do so. Everything you put as HTML will be ignored anyway.
@Niteletsplay you can now simply add an event listener called change.
const d = getDropdown("test1")
d!.addEventListener("change", function() {
console.log(getValue("test1"));
});
@Niteletsplay should change also be executed on selecting the item already selected and therefore not change of the value?
@Niteletsplay should change also be executed on selecting the item already selected and therefore not change of the value?
No, but there shouldnt be a problem if it is
@Niteletsplay now it only has to be implemented in guide
Do we use this implementation in the edit view too?
Dropdowns in edit need to be changed to the new implementation then everything is done
@Niteletsplay don't close this pr
@Niteletsplay don't close this pr
why do you use an innerhtml here @9glenda