css-modules-typescript-loader icon indicating copy to clipboard operation
css-modules-typescript-loader copied to clipboard

Feature-request: Allow custom/no banners for the generated typings file

Open waabid opened this issue 6 years ago • 4 comments
trafficstars

Other loaders allow this kind of customization.

I'd be willing to make the change myself as well.

waabid avatar May 10 '19 18:05 waabid

Im not an owner on this repo or anything special, but are you able to post links to examples of what you mean? I don't actually understand the problem you're trying to solve :)

silbinarywolf avatar May 15 '19 01:05 silbinarywolf

No worries! 😄

Effectively speaking, I'm thinking of something like this: https://github.com/Jimdo/typings-for-css-modules-loader#banner-option

waabid avatar May 15 '19 20:05 waabid

Ah right!

Im personally not sure the cost of being able to customise the banner message is worth it. What tangible benefit is there to adding this feature? What does it enable you to get done?

I used to pack my own modules full of features but nowadays I try to keep things as simple / lightweight as possible, so I'm always considering how much I truly need a feature and if the long-term maintenance cost is worth it, ie. do I want to maintain this feature for 1, 2 or 5 years? How does the feature impact the readability/simplicity of my code?

silbinarywolf avatar May 16 '19 00:05 silbinarywolf

Ah right!

Im personally not sure the cost of being able to customise the banner message is worth it. What tangible benefit is there to adding this feature? What does it enable you to get done?

I used to pack my own modules full of features but nowadays I try to keep things as simple / lightweight as possible, so I'm always considering how much I truly need a feature and if the long-term maintenance cost is worth it, ie. do I want to maintain this feature for 1, 2 or 5 years? How does the feature impact the readability/simplicity of my code?

when migrate from typings-for-css-modules-loader, it cause lots of git diff.

holynewbie avatar Mar 02 '23 04:03 holynewbie