react-data-export icon indicating copy to clipboard operation
react-data-export copied to clipboard

Typescript definitions for components

Open daugsbi opened this issue 7 years ago • 3 comments

Suggestion:

I would like to use this library in a typescript project. I tried to type the index.js file, but I couldn't find a way to express the export definitions in typescript. So I changed the index.js file, but this would be a breaking change in the API. In addition I exported the react component with the existing typings and referenced the types in the package.json.

Please let me know if you would accept a pull request, which introduces breaking changes or if you have any idea how to correctly type index.js.

My reason:

I would like to use this library with typescript.

Steps to reproduce:

Check the changes in the fork. https://github.com/daugsbi/react-data-export

daugsbi avatar Jul 28 '18 11:07 daugsbi

Hi @daugsbi,

Thank you for deciding to participate to this library, and sorry for the delayed response as I was on summer vacations,

You are welcome to submit a PR and I will review it on my priority,

Br,

securedeveloper avatar Aug 06 '18 13:08 securedeveloper

Yes Please!

harry-sm avatar Sep 11 '18 21:09 harry-sm

@daugsbi can you please submit your pull request, I had a chance to look at your code and it seems good to me, thanks.

securedeveloper avatar Oct 03 '18 16:10 securedeveloper