SDVersion icon indicating copy to clipboard operation
SDVersion copied to clipboard

2018 devices

Open skuske opened this issue 7 years ago • 14 comments

When will this support the new 2018 devices? Thanks.

skuske avatar Sep 13 '18 07:09 skuske

up

fabiosoft avatar Sep 13 '18 11:09 fabiosoft

+1

xuning0 avatar Sep 14 '18 10:09 xuning0

+1

raulrom13 avatar Sep 14 '18 11:09 raulrom13

+1

andforce avatar Sep 14 '18 14:09 andforce

+1

mqch295 avatar Sep 17 '18 06:09 mqch295

There's two pull requests implementing these changes (I'm partial to my own https://github.com/sebyddd/SDVersion/pull/90, but either will mostly do).

Feel free to set your pod file to use my fork: pod 'SDVersion', git: 'https://github.com/cguess/SDVersion' while waiting for one of them to be accepted.

cguess avatar Sep 18 '18 00:09 cguess

@cguess

Cool, thanks. What about the new Watch devices?

skuske avatar Sep 18 '18 05:09 skuske

+1

jyhud avatar Sep 18 '18 07:09 jyhud

@cguess

Cool, thanks. What about the new Watch devices?

Honestly @skuske, I forgot. I haven't done a ton of WatchOS development but I'll try and get a fix in ASAP.

cguess avatar Sep 18 '18 09:09 cguess

@cguess cool

CaiChenghan avatar Sep 19 '18 03:09 CaiChenghan

@skuske it's now updated with the new 40mm and 44mm watch sizes. I'm guessing (intelligently) on the watch models, since neither I nor anyone else has them yet, but it should be solid.

cguess avatar Sep 19 '18 13:09 cguess

@skuske it's now updated with the new 40mm and 44mm watch sizes. I'm guessing (intelligently) on the watch models, since neither I nor anyone else has them yet, but it should be solid.

There's two pull requests implementing these changes (I'm partial to my own #90, but either will mostly do).

Feel free to set your pod file to use my fork: pod 'SDVersion', git: 'https://github.com/cguess/SDVersion' while waiting for one of them to be accepted.

screenHeight = [[UIScreen mainScreen] nativeBounds].size.height this wrong In the case of using the plus series

JaterLee avatar Nov 03 '18 03:11 JaterLee

But write podspec cannot use s.dependency 'SDVersion', git: 'https://github.com/cguess/SDVersion', Please release 2018 iOS devices @sebyddd

poholo avatar Dec 27 '18 07:12 poholo

@cguess How can I use your repo of a podspec ? s.dependency 'SDVersion', git: 'https://github.com/cguess/SDVersion'

poholo avatar Jan 05 '19 06:01 poholo

@poholo sorry about the delay with the holidays. I'll look into it ASAP

cguess avatar Jan 07 '19 14:01 cguess