Implement Media Filters

[hishamco]

This should include: img_tag and video_tag at least

[deanebarker]

Explain how you think these should work. I looked through the Liquid doc and didn't see them there.

What type of value would these operate on? What would these output?

[hishamco]

@deanebarker please refer to https://shopify.dev/api/liquid/filters/media-filters#img_tag and https://shopify.dev/api/liquid/filters/media-filters#video_tag

[deanebarker]

The filters on that page are Shopify-specific. Do you want these for raw Fluid, Fluid used as a ViewEngine, or Fluid used in some application?

[hishamco]

While Fluid based on Liquid, such filters will be a plus, moreover they will be helpful for Orchard Core

[deanebarker]

But, again, those filters aren't technically on Liquid. They're part of Shopify.

Yes, but the problem is that forming a path to anything requires knowledge of where that thing is. In Shopify, it looks like these filters work on some kind of image value?

So we'd need two things:

1. An ImageValue based on FluidValue
2. Some knowledge of the URL path to that image

This is theoretically possible in raw Fluid, but I don't know how helpful it would be.

If you want to use this in Orchard (which makes sense because Orchard has knowledge of the URL pathing) , then I feel like this is a ticket for that project.

[hishamco]

If you want to use this in Orchard (which makes sense because Orchard has knowledge of the URL pathing) , then I feel like this is a ticket for that project.

There are some project drive Orchard Core project, but that doesn't mean it could be useful for other project, BTW if some filters are Orchard Core specific we could add them in OC, thanks for Fluid extensibility

Thanks for your feedback

[sebastienros]

I am in favor of implementing Shopify's specific filters or tags as long as they are physically separated. For instance we could have a dedicated nuget package, with the theming tags, ... Though some of it might not work at all since they also rely on their content model (page, blog, products, ...).

This way someone who wants to remain bound to the official language won't have to answer to support these.

There might already be some filters that are not officially in Liquid, but are nice to have. These might have to move eventually, or at least be optional.

[deanebarker]

I would probably do this as an identifier on a new value class? If you do it as a filter, then it could be used on something which doesn't have a URL, which wouldn't make sense.

Totally untested code...

public class ImageValue : FluidValue
{
  public static string PathTemplate { get; set; }

  private string _filename;

  public ImageValue(string filename)
  {
    _filename = filename;
  }

  protected override FluidValue GetValue(string name, TemplateContext context)
  {
    if(!string.IsNullOrWhiteSpace(PathTemplate) && name == "url")
    {
      return string.Format(PathTemplate, _filename);
    }
    return NilValue.Instance;
  }

  [lots of other stuff here]
}


ValueTask<FluidValue> ImageTag(FluidValue input, FilterArguments arguments, TemplateContext context)
{
  return new StringValue("<img src=\"" + input.ToStringValue() + "\">";
}
TemplateOptions.Default.Filters.AddFilter("img_tag", ImageTag);

Then you could do this in C#:

ImageValue.PathTemplate = "/images/{0}";

context.SetValue("main_image", new ImageValue("main_image.png"));
context.SetValue("header_image", new ImageValue("main_image.png"));

And in Fluid:

{{ main_image.url | img_tag }}

[hishamco]

@deanebarker are you interest to submit a PR for this?