Sébastien Ros

Results 1074 comments of Sébastien Ros

The doc says it is supported https://learn.microsoft.com/en-us/sql/t-sql/language-elements/slash-star-comment-transact-sql?view=sql-server-ver16#remarks

On my PRs the test failed on timeout: ``` info: Nats.AppHost.Resources.api[0] 11: 2024-08-14T00:22:14.7931115 info: Microsoft.Hosting.Lifetime[0] info: Nats.AppHost.Resources.api[0] 12: Content root path: /datadisks/disk1/work/A75A0945/w/9CC70908/e/playground/nats/Nats.ApiService Aborting test run: test run timeout of 600000...

I personally don't take **throughput** as an indicator of performance, but a way to check that the network is not a bottleneck and that the benchmark works as expected. And...

This is too intrusive (in the ctor). Can this `StringComparer` be yet another property of the options/context classes, be inherited like the other properties? And the new property should be...

@gumbarros if you can't do the changes @hishamco or myself should be able to do it.

> To be honest it was as it's seen in https://github.com/sebastienros/fluid/commit/b99e0f54853fbebf42101758f24388917e2ac32f Did I actually ask the opposite, or was it done on your own thoughts?

In you case that's what you mean, it's pretty common to see the properties duplicated and cloned from `TemplateOptions` and `TemplateContext`. But this is done this way for anything that...

Updated it. Should be simpler, and it helped me realize that this property can't be changed dynamically as it is used by an inner collection. In Fluid 3.0 we might...

@nguyenngocanhpro do you want to submit a PR for GetValueAsync? I can ship it right after that.

The link you provided is from liquidjs, not shopify, here is the result from Shopify (https://shopify.dev/docs/api/liquid) ![image](https://github.com/user-attachments/assets/0891b1a7-5225-48cf-b5fc-3c9a570b0c2a)