Sébastien Ros

Results 1037 comments of Sébastien Ros

I like what you are doing here but I don't think it should be part of the engine natively. I suggest you keep it in your source code or create...

But I might change my mind later on. I see you haven't added any external dependencies which I like.

I am in favor of implementing Shopify's specific filters or tags as long as they are physically separated. For instance we could have a dedicated nuget package, with the theming...

Would make sense to use this. But I need to think about the implications with targets.

You mean because right now it's strings in and out? I believe you can already use a TextWriter as the output.

You will need the `IAsyncEnumerable` support for your input example.

Please go for it if you think you can implement it

https://shopify.dev/api/liquid/objects/paginate https://shopify.dev/api/liquid/objects/part

Wouldn't it make more sense by using `{{ obj }}` instead? The render tag was introduced also for its caching semantics which I think this PR is breaking.

> We already have {% render 'snippet' %} And they explicitly made `'snippet'` be only string literal in `render` when it was introduced to "fix" the `include` tag so the...