Sébastien Ros

Results 1037 comments of Sébastien Ros

I might understand the issue now. Are you trying to invoke `FluidParser.Parse(filename)` with a template that comes from the database? Currently the `options.FileProvider` is only used for include tags. Is...

Have you tried to set this options: ``` FluidViewEngineOptions.ViewsFileProvider FluidViewEngineOptions.PartialsFileProvider ``` If they are not set it will use `IHostingEnvironment.ContentRootFileProvider`. I assume you could also set `IHostingEnvironment.ContentRootFileProvider` directly.

Source of the problem: https://github.com/sebastienros/fluid/blob/main/Fluid/Values/StringValue.cs#L139 There are a few other locations using `InvariantCulture` explicitly instead of the configured culture. We need to think about each case, it's not obvious to...

test cases: `{{ '3,5' | plus: 1 }}` Note that the liquid template has to use the invariant numbers natively, it's part of the language. `{{ 1.5 | plus: '1,5'...

Looks like Shopify's Liquid expects an invariant string as the input: https://github.com/Shopify/liquid/blob/68c3827ef21945c48c273e40a7cb5ac68b68eb30/lib/liquid/utils.rb#L55 I am not opposed to using the configured culture even for inputs, but that would mean that it's...

Dots are not supported in filter names, in Liquid. `-` and `_` are however. I am not opposed to having this being a flag, like other extensions to the language....

The only caveat with attributes is that your model has a dependency on Fluid. If you are fine with that, that's good, or we could have an overload of `Register`...

Confirmed when adding this test ```c# [Fact] public Task ShouldRegisterDateTimeOffset() { var options = new TemplateOptions(); options.MemberAccessStrategy.Register(); return Task.CompletedTask; } ```

It will now prevent you from compiling by ensuring that `T` is a reference type.

Thanks @jg-rp for the test cases. Do you know what is the rule to relate loops between each others? For instance what if there is a loop on `(1..6)` then...