Sébastien Ros
Sébastien Ros
Checkout your branch. `git reset --mixed 1.10.x` This will move the `HEAD` of your branch to `1.10.x`, without changing any file. It means that now git sees all the changes...
And now that it's clean, we can see the breaking changes ... IContentFieldDriver and IContentPartDriver new methods.
I will join 15 minutes the meeting if you want. Ping me if I forget.
I'd say IContentFieldCloningDriver ,same for parts, inheriting from IContentFieldDriver. And in the dev branch we remove it.
The simplest way to remove reflection is just to check if the instance of the driver `IsAssignableFrom` an `IContentPartCloningDriver `, and if so cast it to it. Don't need to...
What about this: If someone wants to implement custom cloning, they implement `IContentPartCloningDriver` also. From the coordinator (the service that calls the drivers) in the Clone methods, cast each driver...
In your example you could have Cloned/Cloning in the base class, and you can just call `base.Cloned` in the else statement.
Try to have the default behavior in the base classes (field and driver). If someone implemented IContentPartDriver directly (without the abstract class) then you can detect it from the coordinator...
Add /en/latest before the path in the meantime. Must be an issue with readthedocs as on Google it's indexed correctly without this prefix.
Just one comment as I need to play more with it to say anything. About the independently scrolling menu, I remember that I was in favor of that too because...