angular-bootstrap-checkbox icon indicating copy to clipboard operation
angular-bootstrap-checkbox copied to clipboard

Remove bootstrap from dependecies

Open teone opened this issue 9 years ago • 5 comments

Hello @sebastianha, thanks for your awesome work with this directive!

What about removing bootstrap (css + jquery) as a dependency for this module?

I guess that if someone is looking for this directive has already bootstrap included, and if not what about including only the checkbox related style? I think it is not useful to download a full library to use just a small piece of it. What do you think about?

In case I can help with that

teone avatar Feb 26 '16 16:02 teone

Hi,

as you pointed out the most people will already include bootstrap into their project and then a version without bootstrap would add duplicate code for the checkbox.

Perhaps I coult create a build process where two versions are build, one without (and with bootstrap) and one with the checkbox related style.

sebastianha avatar Mar 04 '16 09:03 sebastianha

I guess this will be the best option, but how would you handle a different bower.json? Bootstrap is listed there as a dependecy. Is that possible?

teone avatar Mar 04 '16 16:03 teone

Mmmh, I don't know if there is a way to handle this. Perhaps we could create a new branch for the non-bootstrap version with a different bower.json?

sebastianha avatar Mar 04 '16 17:03 sebastianha

I don't se any other way... I guess we should find a way to manage 2 different version of the same package with bower... I'll take a look and come back (hopefully with some news)...

teone avatar Mar 05 '16 00:03 teone

Why not just bump the bower package version respecting the semver and inducing a breaking change?

ghost avatar Nov 09 '16 10:11 ghost