phpbu icon indicating copy to clipboard operation
phpbu copied to clipboard

Published 20 hours ago • verified publisher icon sebastianfeldmann

Upgrade to `phpseclib` version 3

Open getpinga opened this issue 2 years ago • 2 comments

Is there a reason why phpseclib/phpseclib 3.0 is not supported?

Can I help somehow to add support for it?

Thanks

getpinga avatar Nov 27 '23 14:11 getpinga

No particular reason. If we don't have to make weird version if else stuff I don't see any reason to not support it.

sebastianfeldmann avatar Nov 27 '23 19:11 sebastianfeldmann

phpseclib changed a lot of the API phpbu uses to do SFTP stuff.

Currently there is no way to support both out of the box because the changes are to big to handle in a couple of if else.

Either, we have to build a SFTPClient interface and write the SFTPClientPHPSecLibV2 and SFTPClientPHPSecLibV3 implementations. Then change all phpbu stuff to use the SFTPClient interface and finally write a SFTPClientFactory that creates a client depending on what dependency is loaded.

OR and that would be my preferred way kill support for everything below phpseclib v3 and update everything so it works with the latest version.

sebastianfeldmann avatar Dec 22 '23 12:12 sebastianfeldmann